Re: [PATCH v4 5/6] arm64: dts: qcom: ipq5018: add nodes required for Bluetooth support

[George Moussalem]

On 7/7/26 12:27, Konrad Dybcio wrote:
> On 7/7/26 10:12 AM, George Moussalem wrote:
>> On 7/7/26 11:51, Konrad Dybcio wrote:
>>> On 7/7/26 9:51 AM, Konrad Dybcio wrote:
>>>> On 7/6/26 7:26 PM, George Moussalem via B4 Relay wrote:
>>>>> From: George Moussalem <george.moussalem@xxxxxxxxxxx>
>>>>>
>>>>> Add nodes for the reserved memory carveout and Bluetooth.
>>>>>
>>>>> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
>>>>> Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
>>>>> ---
>>>>
>>>> [...]
>>>>
>>>>> @@ -136,6 +153,11 @@ reserved-memory {
>>>>>  		#size-cells = <2>;
>>>>>  		ranges;
>>>>>  
>>>>> +		btss_region: bluetooth@7000000 {
>>>>> +			reg = <0x0 0x07000000 0x0 0x58000>;
>>>>
>>>> FWIW RAM starts at 0x4000_0000 - I'm thinking whether this should
>>>> just be the 'reg' value of the bluetooth node. This makes even more
>>>> sense as you write to this region using I/O accessors
>>
>> I wasn't sure whether setting the unit address to the memory region it
>> uses and write to. Perhaps Bjorn/Krzysztof can provide guidance?
>> So essentially, the proposal would be for the bluetooth node without a
>> reg property to look like:
>>
>> bluetooth@7000000 {
>> ...
>> 	memory-region = <&btss_region>	--> which starts at 0x07000000
> 
> I was proposing that we remove the reserved-memory region and define
> this register range only through the 'reg' property.

Got it. Will update the driver, bindings, and dt node accordingly.

> 
>> };
>>  > FWIW2: The region is called "BT_RAM"
>>>
>>> Konrad
>>
>> Thanks, I'll update the node name of the memory region to bt_ram@7000000
> 
> Node names (between ':' and '@') must not contain underscores, use a
> hyphen there.
> 
> Konrad

Best regards,
George