Re: [PATCH v2 6/6] arm64: dts: qcom: qcs6490-rubikpi3: Add audio support

[Konrad Dybcio]

On 7/18/26 11:41 AM, Hongyang Zhao wrote:
> On 7/15/26 4:02 PM, Hongyang Zhao wrote:
>>> RubikPi 3 uses the AudioReach firmware path for its external audio
>>> interfaces. The primary MI2S interface connects to an ES8316 codec for
>>> headset playback and capture, while the quaternary MI2S interface feeds
>>> the LT9611 HDMI bridge.
>>
>> [...]
>>
>>> +	vreg_es8316_3v3: regulator-es8316-3v3 {
>>> +		compatible = "regulator-fixed";
>>> +
>>> +		regulator-name = "vreg_es8316_3v3";
>>> +		regulator-min-microvolt = <3300000>;
>>> +		regulator-max-microvolt = <3300000>;
>>> +
>>> +		gpio = <&tlmm 117 GPIO_ACTIVE_HIGH>;
>>> +		enable-active-high;
>>> +
>>> +		pinctrl-0 = <&es8316_power_on>;
>>> +		pinctrl-names = "default";
>>> +
>>> +		regulator-always-on;
>>> +		regulator-boot-on;
>>
>> Does it need to be always-on? Is it really on at boot time?
> 
> I think the regulator-always-on constraint is currently required.
> GPIO117 controls the power switch for the ES8316, but the existing
> ES8316 binding and driver do not model regulator supplies.

Please fix that first.

Konrad