[PATCH 2/5] serial: imx: Remove redundant dev_err()

From: Pan Chuang

Date: Tue Jul 21 2026 - 23:47:25 EST


Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/tty/serial/imx.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 251a50c8aa38..95fdb60e06a7 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2602,34 +2602,23 @@ static int imx_uart_probe(struct platform_device *pdev)
if (txirq > 0) {
ret = devm_request_irq(&pdev->dev, rxirq, imx_uart_rxint, 0,
dev_name(&pdev->dev), sport);
- if (ret) {
- dev_err(&pdev->dev, "failed to request rx irq: %d\n",
- ret);
+ if (ret)
goto err_clk;
- }

ret = devm_request_irq(&pdev->dev, txirq, imx_uart_txint, 0,
dev_name(&pdev->dev), sport);
- if (ret) {
- dev_err(&pdev->dev, "failed to request tx irq: %d\n",
- ret);
+ if (ret)
goto err_clk;
- }

ret = devm_request_irq(&pdev->dev, rtsirq, imx_uart_rtsint, 0,
dev_name(&pdev->dev), sport);
- if (ret) {
- dev_err(&pdev->dev, "failed to request rts irq: %d\n",
- ret);
+ if (ret)
goto err_clk;
- }
} else {
ret = devm_request_irq(&pdev->dev, rxirq, imx_uart_int, 0,
dev_name(&pdev->dev), sport);
- if (ret) {
- dev_err(&pdev->dev, "failed to request irq: %d\n", ret);
+ if (ret)
goto err_clk;
- }
}

imx_uart_ports[sport->port.line] = sport;
--
2.34.1