Re: [PATCH v2 02/10] hwmon: Add Qualcomm PMIC BCL driver

From: Manaf Meethalavalappu Pallikunhi

Date: Thu Jul 23 2026 - 03:42:29 EST


Hi Uwe,

On 7/23/2026 11:59 AM, Uwe Kleine-König wrote:
Hello,

On Wed, Jul 22, 2026 at 12:00:07AM +0530, Manaf Meethalavalappu Pallikunhi wrote:
+#include <linux/mod_devicetable.h>
[...]
+#include <linux/platform_device.h>

<linux/platform_device.h> already provides struct of_device_id and
<linux/mod_devicetable.h> will go away soon. So please drop the #include
for <linux/mod_devicetable.h>.

ACK, thanks for the review, will remove it in next revision.

Thanks,
Manaf


Best regards
Uwe