Re: [PATCH] iio: chemical: cleanup codestyle warning
From: Joshua Crofts
Date: Thu Jul 23 2026 - 17:51:57 EST
On Fri, 24 Jul 2026 00:10:38 +0800
Adi Nata <adinata.softwareengineer@xxxxxxxxx> wrote:
> Reported by checkpatch:
> FILE: drivers/iio/chemical/ccs811.c
>
> WARNING: Prefer __packed over __attribute__((__packed__))
> +} __attribute__((__packed__));
Perhaps a nit, but I'd change the commit title to "prefer __packed"
and the commit message to something like:
"Change instance of __attribute__((__packed__)) to __packed per
checkpatch.pl warning.
Other than that:
Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
>
> Signed-off-by: Adi Nata <adinata.softwareengineer@xxxxxxxxx>
> ---
> drivers/iio/chemical/ccs811.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
> index ce7187ccd706..0e5c79b775a2 100644
> --- a/drivers/iio/chemical/ccs811.c
> +++ b/drivers/iio/chemical/ccs811.c
> @@ -70,7 +70,7 @@ struct ccs811_reading {
> u8 status;
> u8 error;
> __be16 raw_data;
> -} __attribute__((__packed__));
> +} __packed;
>
> struct ccs811_data {
> struct i2c_client *client;
--
Kind regards,
Joshua Crofts