Re: [PATCH v3 3/4] hwmon: (kb9002) Add driver for Kandou KB9002 retimer

From: Andy Chung

Date: Fri Jul 24 2026 - 01:26:26 EST


On Tue, 21 Jul 2026 07:43:11 -0700, Guenter Roeck wrote:
> Doesn't this depend on controller PEC support (I2C_FUNC_SMBUS_PEC) ?
> Also, the driver depends on I2C_FUNC_SMBUS_BLOCK_DATA support,
> which is not always available. I would suggest to check for both.

probe() already requires both before setting I2C_CLIENT_PEC:

if (!i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_BLOCK_DATA |
I2C_FUNC_SMBUS_PEC))
return -ENODEV;

so the flag is only set on adapters that support PEC. The endianness,
is_visible and temp1_label comments are addressed in v5.

Thanks,
Andy