Re: [cocci] [1/36] coccinelle: misc: add cond_return_no_effect.cocci

[Sang-Heon Jeon]

On Sat, Jul 25, 2026 at 12:32 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> >> …
> >>> +++ b/scripts/coccinelle/misc/cond_return_no_effect.cocci
> …
> > Combining them with two separate metavariables would be okay,
>
> Thanks that you can think a bit more about such a design variant.
>
>
> >                                                               but I
> > don't see much benefit in that change.
>
> Further metavariables can eventually be shared for an SmPL rule.
>
> How do you think about to avoid repeated search efforts by separate SmPL rules
> (for the patch mode)?

Are there impressive performance improvements from merging the rules?
If so, could you share an example or numbers?

>
> >                                        So I'd prefer to stay existing
> > form.
> There are different SmPL coding style preferences involved.
>
> Regards,
> Markus