Re: [PATCH v2 2/2] media: i2c: Add Samsung S5KJN5 image sensor driver

[Vladimir Zapolskiy]

On 7/24/26 12:50, Wenmeng Liu wrote:
> Add a V4L2 sub-device driver for the Samsung S5KJN5, a 50 MP GBRG 10-bit
> RAW MIPI CSI-2 image sensor. The driver supports the 4096x3072 mode and
> exposes the standard controls (exposure, gain, vblank/hblank, test
> pattern).
>
> Signed-off-by: Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>

<snip>

> +
> +static const struct s5kjn5_init_op s5kjn5_init_ops[] = {
> +	{ .reg = CCI_REG16(0xfcfc), .val = 0x4000 },
> +	{ .reg = CCI_REG16(0x0000), .val = 0x000e },
> +	{ .reg = CCI_REG16(0x0000), .val = 0x38e5 },

One more comment:

.val = S5KJN5_CHIP_ID

> +	{ .reg = CCI_REG16(0x6018), .val = 0x0001 },
> +	{ .reg = CCI_REG16(0x7002), .val = 0x0408 },
> +	{ .reg = CCI_REG16(0x6014), .val = 0x0001 },
> +	{ .reg = CCI_REG16(0xfcfc), .val = 0x2002 },
> +	{ .reg = CCI_REG16(0x1e92), .val = 0x8000 },
> +	{ .reg = CCI_REG8(0x1e84), .val = 0x28 },
> +	{ .reg = CCI_REG8(0x1e85), .val = 0x2b },
> +	{ .reg = CCI_REG8(0x1e86), .val = 0x03 },
> +	{ .reg = CCI_REG8(0x1e87), .val = 0x20 },
> +	{ .reg = CCI_REG16(0xfcfc), .val = 0x4000 },
> +	{ .reg = CCI_REG16(0x7002), .val = 0x0008 },
> +	{ .delay_us = 5000 },

--
Best wishes,
Vladimir