[PATCH] greybus: audio_manager: fix sysfs_emit newline and const warnings
From: Shivesh
Date: Sat Jul 25 2026 - 09:44:36 EST
Add terminating newlines to sysfs_emit() format strings as required
by the kernel sysfs convention. Also make envp[] array const to fix
checkpatch warning about char* array declaration.
Signed-off-by: Shivesh <chanelshivesh@xxxxxxxxx>
Signed-off-by: Shivesh <shivesh@xxxxxxxxxxx>
---
drivers/staging/greybus/audio_manager_module.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index dc90cc2d2308..74ea495e1c19 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj)
static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
struct gb_audio_manager_module_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%s", module->desc.name);
+ return sysfs_emit(buf, "%s\n", module->desc.name);
}
static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
@@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module,
struct gb_audio_manager_module_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%d", module->desc.vid);
+ return sysfs_emit(buf, "%d\n", module->desc.vid);
}
static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
@@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module,
struct gb_audio_manager_module_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%d", module->desc.pid);
+ return sysfs_emit(buf, "%d\n", module->desc.pid);
}
static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute =
@@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu
struct gb_audio_manager_module_attribute *attr,
char *buf)
{
- return sysfs_emit(buf, "%d", module->desc.intf_id);
+ return sysfs_emit(buf, "%d\n", module->desc.intf_id);
}
static struct gb_audio_manager_module_attribute
@@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m
struct gb_audio_manager_module_attribute *attr,
char *buf)
{
- return sysfs_emit(buf, "0x%X", module->desc.ip_devices);
+ return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices);
}
static struct gb_audio_manager_module_attribute
@@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m
struct gb_audio_manager_module_attribute *attr,
char *buf)
{
- return sysfs_emit(buf, "0x%X", module->desc.op_devices);
+ return sysfs_emit(buf, "0x%X\n", module->desc.op_devices);
}
static struct gb_audio_manager_module_attribute
@@ -158,7 +158,7 @@ static void send_add_uevent(struct gb_audio_manager_module *module)
char ip_devices_string[64];
char op_devices_string[64];
- char *envp[] = {
+ const char *const envp[] = {
name_string,
vid_string,
pid_string,
--
2.53.0
--===============7220607961872909415==
Content-Type: application/octet-stream
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="0001-greybus-audio_manager-fix-sysfs_emit-newline-and-con.patch"
RnJvbSA1ZTBiY2I0OTIwYmNiOWUwZWY2YzAzYTkxNzMwZmU0NWY2NDNmM2E0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTaGl2ZXNoIDxzaGl2ZXNoQGV4YW1wbGUuY29tPgpEYXRlOiBT
YXQsIDI1IEp1bCAyMDI2IDEzOjQ0OjM2ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gZ3JleWJ1czog
YXVkaW9fbWFuYWdlcjogZml4IHN5c2ZzX2VtaXQgbmV3bGluZSBhbmQgY29uc3QKIHdhcm5pbmdz
CgpBZGQgdGVybWluYXRpbmcgbmV3bGluZXMgdG8gc3lzZnNfZW1pdCgpIGZvcm1hdCBzdHJpbmdz
IGFzIHJlcXVpcmVkCmJ5IHRoZSBrZXJuZWwgc3lzZnMgY29udmVudGlvbi4gQWxzbyBtYWtlIGVu
dnBbXSBhcnJheSBjb25zdCB0byBmaXgKY2hlY2twYXRjaCB3YXJuaW5nIGFib3V0IGNoYXIqIGFy
cmF5IGRlY2xhcmF0aW9uLgoKU2lnbmVkLW9mZi1ieTogU2hpdmVzaCA8Y2hhbmVsc2hpdmVzaEBn
bWFpbC5jb20+ClNpZ25lZC1vZmYtYnk6IFNoaXZlc2ggPHNoaXZlc2hAZXhhbXBsZS5jb20+Ci0t
LQogZHJpdmVycy9zdGFnaW5nL2dyZXlidXMvYXVkaW9fbWFuYWdlcl9tb2R1bGUuYyB8IDE0ICsr
KysrKystLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9u
cygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy9ncmV5YnVzL2F1ZGlvX21hbmFnZXJf
bW9kdWxlLmMgYi9kcml2ZXJzL3N0YWdpbmcvZ3JleWJ1cy9hdWRpb19tYW5hZ2VyX21vZHVsZS5j
CmluZGV4IGRjOTBjYzJkMjMwOC4uNzRlYTQ5NWUxYzE5IDEwMDY0NAotLS0gYS9kcml2ZXJzL3N0
YWdpbmcvZ3JleWJ1cy9hdWRpb19tYW5hZ2VyX21vZHVsZS5jCisrKyBiL2RyaXZlcnMvc3RhZ2lu
Zy9ncmV5YnVzL2F1ZGlvX21hbmFnZXJfbW9kdWxlLmMKQEAgLTc1LDcgKzc1LDcgQEAgc3RhdGlj
IHZvaWQgZ2JfYXVkaW9fbW9kdWxlX3JlbGVhc2Uoc3RydWN0IGtvYmplY3QgKmtvYmopCiBzdGF0
aWMgc3NpemVfdCBnYl9hdWRpb19tb2R1bGVfbmFtZV9zaG93KHN0cnVjdCBnYl9hdWRpb19tYW5h
Z2VyX21vZHVsZSAqbW9kdWxlLAogCQkJCQkgc3RydWN0IGdiX2F1ZGlvX21hbmFnZXJfbW9kdWxl
X2F0dHJpYnV0ZSAqYXR0ciwgY2hhciAqYnVmKQogewotCXJldHVybiBzeXNmc19lbWl0KGJ1Ziwg
IiVzIiwgbW9kdWxlLT5kZXNjLm5hbWUpOworCXJldHVybiBzeXNmc19lbWl0KGJ1ZiwgIiVzXG4i
LCBtb2R1bGUtPmRlc2MubmFtZSk7CiB9CiAKIHN0YXRpYyBzdHJ1Y3QgZ2JfYXVkaW9fbWFuYWdl
cl9tb2R1bGVfYXR0cmlidXRlIGdiX2F1ZGlvX21vZHVsZV9uYW1lX2F0dHJpYnV0ZSA9CkBAIC04
NCw3ICs4NCw3IEBAIHN0YXRpYyBzdHJ1Y3QgZ2JfYXVkaW9fbWFuYWdlcl9tb2R1bGVfYXR0cmli
dXRlIGdiX2F1ZGlvX21vZHVsZV9uYW1lX2F0dHJpYnV0ZSA9CiBzdGF0aWMgc3NpemVfdCBnYl9h
dWRpb19tb2R1bGVfdmlkX3Nob3coc3RydWN0IGdiX2F1ZGlvX21hbmFnZXJfbW9kdWxlICptb2R1
bGUsCiAJCQkJCXN0cnVjdCBnYl9hdWRpb19tYW5hZ2VyX21vZHVsZV9hdHRyaWJ1dGUgKmF0dHIs
IGNoYXIgKmJ1ZikKIHsKLQlyZXR1cm4gc3lzZnNfZW1pdChidWYsICIlZCIsIG1vZHVsZS0+ZGVz
Yy52aWQpOworCXJldHVybiBzeXNmc19lbWl0KGJ1ZiwgIiVkXG4iLCBtb2R1bGUtPmRlc2Mudmlk
KTsKIH0KIAogc3RhdGljIHN0cnVjdCBnYl9hdWRpb19tYW5hZ2VyX21vZHVsZV9hdHRyaWJ1dGUg
Z2JfYXVkaW9fbW9kdWxlX3ZpZF9hdHRyaWJ1dGUgPQpAQCAtOTMsNyArOTMsNyBAQCBzdGF0aWMg
c3RydWN0IGdiX2F1ZGlvX21hbmFnZXJfbW9kdWxlX2F0dHJpYnV0ZSBnYl9hdWRpb19tb2R1bGVf
dmlkX2F0dHJpYnV0ZSA9CiBzdGF0aWMgc3NpemVfdCBnYl9hdWRpb19tb2R1bGVfcGlkX3Nob3co
c3RydWN0IGdiX2F1ZGlvX21hbmFnZXJfbW9kdWxlICptb2R1bGUsCiAJCQkJCXN0cnVjdCBnYl9h
dWRpb19tYW5hZ2VyX21vZHVsZV9hdHRyaWJ1dGUgKmF0dHIsIGNoYXIgKmJ1ZikKIHsKLQlyZXR1
cm4gc3lzZnNfZW1pdChidWYsICIlZCIsIG1vZHVsZS0+ZGVzYy5waWQpOworCXJldHVybiBzeXNm
c19lbWl0KGJ1ZiwgIiVkXG4iLCBtb2R1bGUtPmRlc2MucGlkKTsKIH0KIAogc3RhdGljIHN0cnVj
dCBnYl9hdWRpb19tYW5hZ2VyX21vZHVsZV9hdHRyaWJ1dGUgZ2JfYXVkaW9fbW9kdWxlX3BpZF9h
dHRyaWJ1dGUgPQpAQCAtMTAzLDcgKzEwMyw3IEBAIHN0YXRpYyBzc2l6ZV90IGdiX2F1ZGlvX21v
ZHVsZV9pbnRmX2lkX3Nob3coc3RydWN0IGdiX2F1ZGlvX21hbmFnZXJfbW9kdWxlICptb2R1CiAJ
CQkJCSAgICBzdHJ1Y3QgZ2JfYXVkaW9fbWFuYWdlcl9tb2R1bGVfYXR0cmlidXRlICphdHRyLAog
CQkJCQkgICAgY2hhciAqYnVmKQogewotCXJldHVybiBzeXNmc19lbWl0KGJ1ZiwgIiVkIiwgbW9k
dWxlLT5kZXNjLmludGZfaWQpOworCXJldHVybiBzeXNmc19lbWl0KGJ1ZiwgIiVkXG4iLCBtb2R1
bGUtPmRlc2MuaW50Zl9pZCk7CiB9CiAKIHN0YXRpYyBzdHJ1Y3QgZ2JfYXVkaW9fbWFuYWdlcl9t
b2R1bGVfYXR0cmlidXRlCkBAIC0xMTQsNyArMTE0LDcgQEAgc3RhdGljIHNzaXplX3QgZ2JfYXVk
aW9fbW9kdWxlX2lwX2RldmljZXNfc2hvdyhzdHJ1Y3QgZ2JfYXVkaW9fbWFuYWdlcl9tb2R1bGUg
Km0KIAkJCQkJICAgICAgIHN0cnVjdCBnYl9hdWRpb19tYW5hZ2VyX21vZHVsZV9hdHRyaWJ1dGUg
KmF0dHIsCiAJCQkJCSAgICAgICBjaGFyICpidWYpCiB7Ci0JcmV0dXJuIHN5c2ZzX2VtaXQoYnVm
LCAiMHglWCIsIG1vZHVsZS0+ZGVzYy5pcF9kZXZpY2VzKTsKKwlyZXR1cm4gc3lzZnNfZW1pdChi
dWYsICIweCVYXG4iLCBtb2R1bGUtPmRlc2MuaXBfZGV2aWNlcyk7CiB9CiAKIHN0YXRpYyBzdHJ1
Y3QgZ2JfYXVkaW9fbWFuYWdlcl9tb2R1bGVfYXR0cmlidXRlCkBAIC0xMjUsNyArMTI1LDcgQEAg
c3RhdGljIHNzaXplX3QgZ2JfYXVkaW9fbW9kdWxlX29wX2RldmljZXNfc2hvdyhzdHJ1Y3QgZ2Jf
YXVkaW9fbWFuYWdlcl9tb2R1bGUgKm0KIAkJCQkJICAgICAgIHN0cnVjdCBnYl9hdWRpb19tYW5h
Z2VyX21vZHVsZV9hdHRyaWJ1dGUgKmF0dHIsCiAJCQkJCSAgICAgICBjaGFyICpidWYpCiB7Ci0J
cmV0dXJuIHN5c2ZzX2VtaXQoYnVmLCAiMHglWCIsIG1vZHVsZS0+ZGVzYy5vcF9kZXZpY2VzKTsK
KwlyZXR1cm4gc3lzZnNfZW1pdChidWYsICIweCVYXG4iLCBtb2R1bGUtPmRlc2Mub3BfZGV2aWNl
cyk7CiB9CiAKIHN0YXRpYyBzdHJ1Y3QgZ2JfYXVkaW9fbWFuYWdlcl9tb2R1bGVfYXR0cmlidXRl
CkBAIC0xNTgsNyArMTU4LDcgQEAgc3RhdGljIHZvaWQgc2VuZF9hZGRfdWV2ZW50KHN0cnVjdCBn
Yl9hdWRpb19tYW5hZ2VyX21vZHVsZSAqbW9kdWxlKQogCWNoYXIgaXBfZGV2aWNlc19zdHJpbmdb
NjRdOwogCWNoYXIgb3BfZGV2aWNlc19zdHJpbmdbNjRdOwogCi0JY2hhciAqZW52cFtdID0gewor
CWNvbnN0IGNoYXIgKmNvbnN0IGVudnBbXSA9IHsKIAkJbmFtZV9zdHJpbmcsCiAJCXZpZF9zdHJp
bmcsCiAJCXBpZF9zdHJpbmcsCi0tIAoyLjUzLjAKCg==
--===============7220607961872909415==--