RE: [PATCH 13/19] wifi: rtw88: sdio: set up RX aggregation and interrupts for RTL8723BS

[Ping-Ke Shih]

Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
> On 24/07/2026 21:32, luka.gejak@xxxxxxxxx wrote:
> > From: Luka Gejak <luka.gejak@xxxxxxxxx>
> >
> > Enable the existing RX aggregation setup for this chip and select the
> > larger DMA aggregation mode it needs. The RTL8723BS does not raise
> > CPWM1, so leave that source out of its interrupt mask, and set the SDIO
> > TX control bit the vendor driver uses to have transfers always
> > recognised.
> >
> > Interrupt status is also acknowledged differently: write back only the
> > bits that are actually defined, and for this chip only those that are
> > unmasked, rather than writing the raw status word back. Writing back
> > undefined bits leaves the RTL8723BS raising a persistent interrupt after
> > resume. Note that restricting the acknowledgment to defined bits
> > applies to the other SDIO parts as well.
> 
> Why does it apply to the others?

Luka, could you answer Bitterblue's questions before sending v2?
You might write the change in cover letter of v2, but it is very hard
for reviewers to know if you did changes based on reviewers' opinions
or you have different reasons. More, please give reviewers more time to
discuss entirely. I don't know that I should reply your v1 or v2 or RFC?

I admit that I have not yet reviewed your patches, but it gets harder
to me since there are many versions. 

Ping-Ke