Re: [PATCH v7 0/5] pinctrl: mediatek: Enable module build support
From: Justin Yeh (葉英茂)
Date: Mon Jul 27 2026 - 01:08:30 EST
On Sat, 2026-07-25 at 15:10 +0200, Linus Walleij wrote:
> On Sat, Jul 25, 2026 at 3:02 PM Linus Walleij <linusw@xxxxxxxxxx>
> wrote:
>
> > All patches applied, I had to rebase patch 5/5, please check the
> > result!
>
> Notably I had to add some lines for MT6858.
>
> Yours,
> Linus Walleij
Thanks for picking up the series, and for covering MT6858 in the
rebase.
I went over your MT6858 additions: the Kconfig entry matches the other
PARIS-based ones, and MODULE_LICENSE()/MODULE_DESCRIPTION()/
MODULE_DEVICE_TABLE() are all in place. No MODULE_IMPORT_NS() is needed
there - pinctrl-paris.c exports its entry points without a namespace,
and mt6858 references no namespaced symbol, same as the other 13
PARIS-based drivers.
Build-tested devel with arm64 allmodconfig (CONFIG_PINCTRL_MT6858=m):
drivers/pinctrl/mediatek/ builds warning-free, and modpost is happy -
no missing-licence or namespace complaints, and the OF aliases for
mt6858 are generated as expected.
One trivial nit, in case you rebase devel again: the attribution line
in
5/5 reads
[linusw@xxxxxxxxxx: Rebased and added MT6858}
with a closing brace instead of a bracket.
Thanks,
Justin