RE: [PATCH v2] cdx: Fix double free when sysfs file creation fails

[Agarwal, Nikhil]

> -----Original Message-----
> From: Prasanna Kumar T S M <ptsm@xxxxxxxxxxxxxxxxxxx>
> Sent: Friday, July 24, 2026 2:57 PM
> To: Gupta, Nipun <Nipun.Gupta@xxxxxxx>; Agarwal, Nikhil
> <nikhil.agarwal@xxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx; Gupta, Puneet (DCG-
> ENG) <puneet.gupta@xxxxxxx>; Gangurde, Abhijit
> <abhijit.gangurde@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> ptsm@xxxxxxxxxxxxxxxxxxx
> Cc: ssengar@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH v2] cdx: Fix double free when sysfs file creation fails
> 
> In cdx_create_res_attr(), if sysfs_create_bin_file() fails, the code frees res_attr but
> doesn't set cdx_dev->res_attr[num] to NULL. This leaves a dangling pointer in the
> array. Then cdx_destroy_res_attr() frees the already-freed memory. Fix the double
> free by initializing cdx_dev->res_attr[num] after sysfs_create_bin_file() completes.
> 
> Fixes: aeda33ab8160 ("cdx: create sysfs bin files for cdx resources")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Prasanna Kumar T S M <ptsm@xxxxxxxxxxxxxxxxxxx>

Acked-by: Nikhil Agarwal <Nikhil.agarwal@xxxxxxx>