Re: [PATCH v5 1/2] dt-bindings: display: bridge: cdns,mhdp8546: Add no-hpd property to the cadence bridge

From: Krzysztof Kozlowski

Date: Wed Jul 29 2026 - 04:26:48 EST


On Tue, Jul 28, 2026 at 09:49:47PM +0530, Yashas D wrote:
>
>
> On 28/07/26 19:59, Rob Herring (Arm) wrote:
> > On Tue, 28 Jul 2026 18: 12: 23 +0530, Yashas D wrote: > From: Rahul T R
> > <r-ravikumar@ ti. com> > > The mhdp bridge can work without its HPD pin
> > hooked up to the connector, > but the current bridge driver throws an
> > error when hpd
> >
> >
> > On Tue, 28 Jul 2026 18:12:23 +0530, Yashas D wrote:
> > > From: Rahul T R <r-ravikumar@xxxxxx>
> > >
> > > The mhdp bridge can work without its HPD pin hooked up to the connector,
> > > but the current bridge driver throws an error when hpd line is not
> > > connected to the connector. For such cases, we need an indication for
> > > no-hpd, using which we can bypass the hpd detection and instead use the
> > > auxiliary channels connected to the DP connector to confirm the
> > > connection.
> > > So add no-hpd property to the bindings, to disable hpd when not
> > > connected or cannot be used for hotplug detection.
> > >
> > > Signed-off-by: Rahul T R <r-ravikumar@xxxxxx>
> > > Signed-off-by: Jayesh Choudhary <j-choudhary@xxxxxx>
> > > Signed-off-by: Yashas D <y-d@xxxxxx>
> > > ---
> > > .../bindings/display/bridge/cdns,mhdp8546.yaml | 17 +++++++++++++++++
> > > 1 file changed, 17 insertions(+)
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml:66:30: [error] syntax error: mapping values are not allowed here (syntax)
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml: ignoring, error parsing file
> > ./Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml: error loading YAML: mapping values are not allowed here
> > in "./Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml", line 66, column 30
> > ./Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml:66:30: mapping values are not allowed here
> > make[2]: *** Deleting file 'Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.example.dts'
> > Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml:66:30: mapping values are not allowed here
> > make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.example.dts] Error 1
> > make[2]: *** Waiting for unfinished jobs....
> > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1703: dt_binding_check] Error 2
> > make: *** [Makefile:248: __sub-make] Error 2
> >
> > doc reference errors (make refcheckdocs):
> >
> > Seehttps://urldefense.com/v3/__https://patchwork.kernel.org/project/
> > devicetree/patch/20260728124224.774785-2-y-d@ti.com__;!!G3vK!W-
> > t7VTYjMiEiiyA5HnNwMPXZXIDl6mIiVFQjSxqG20XM1FTyTXYmNfyADL2cjwLH7WdrUA$ <https://urldefense.com/v3/__https://patchwork.kernel.org/project/devicetree/patch/20260728124224.774785-2-y-d@ti.com__;!!G3vK!W-t7VTYjMiEiiyA5HnNwMPXZXIDl6mIiVFQjSxqG20XM1FTyTXYmNfyADL2cjwLH7WdrUA$>
> >
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
> >
>
> Hi Rob,
> My dt_binding_check had passed, will upgrade and run it again and send a new
> patch.

I doubt, code has obvious syntax issues...

Best regards,
Krzysztof