Re: [PATCH v2 08/11] wifi: rtw88: sdio: set up RX aggregation and interrupts for RTL8723BS

[luka . gejak]

From: Luka Gejak <luka.gejak@xxxxxxxxx>

On 27/07/2026 08:59, Ping-Ke Shih wrote:
>> +               rtwsdio->irq_mask = REG_SDIO_HIMR_RX_REQUEST |
>> +                                      REG_SDIO_HIMR_CPWM1;
> 
> align the REG_*

Fixed.

>> +       if (rtw_is_8723bs(rtwdev))
>> +               rtw_write8_set(rtwdev, REG_RXDMA_MODE, 3 << 2);
> 
> I think you are setting burst count?  rtw_write8_mask()?
> 
> #define BIT_DMA_BURST_CNT	GENMASK(3, 2)

Yes, that is the burst count. Now

  rtw_write8_mask(rtwdev, REG_RXDMA_MODE, BIT_DMA_BURST_CNT, 0x3);

>> +       /* RTL8723BS keeps raising the interrupt after resume if undefined
> 
> comment style

Fixed, along with the rest of the series.

Best regards,
Luka Gejak