Re: [PATCH v7 4/6] arm64: dts: qcom: glymur-crd: Add PHY supplies for pcie3_phy

[Konrad Dybcio]

On 7/29/26 11:50 AM, Qiang Yu wrote:
> On Wed, Jul 29, 2026 at 11:22:45AM +0200, Konrad Dybcio wrote:
>> On 7/29/26 11:11 AM, Qiang Yu wrote:
>>> On Wed, Jul 29, 2026 at 10:30:27AM +0200, Konrad Dybcio wrote:
>>>> On 7/29/26 8:45 AM, Qiang Yu wrote:
>>>>> On Mon, Jul 27, 2026 at 04:47:15PM +0200, Konrad Dybcio wrote:
>>>>>> On 7/24/26 12:01 PM, Qiang Yu wrote:
>>>>>>> CRD wires the shared Gen5x8 PCIe PHY's regulator supplies through
>>>>>>> board-specific PMIC rails. Add the vdda-phy, vdda-pll, and
>>>>>>> vdda-refgen0p9/1p2 supplies for &pcie3_phy.
>>>>>>>
>>>>>>> Signed-off-by: Qiang Yu <qiang.yu@xxxxxxxxxxxxxxxx>
>>>>>>> ---

[...]

>> Do we know what happens if UEFI sets this to x8-mode? (is that even
> 
> UEFI will not set it two x8 mode on crd.
> 
>> a concern on CRDs specifically though?) Will the second controller fail
>> to probe and become a sync_state hog?
> 
> PCIe3b is not enabled in UEFI by default, if we enable it here, we will
> see probe fail.

OK, I'm happy with the patch as-is then

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad