Re: [PATCHv4 net-next] tcp: Add TCP ROCCET congestion control module.

From: Jakub Kicinski

Date: Thu Jul 30 2026 - 19:57:24 EST


On Thu, 23 Jul 2026 10:11:43 +0200 Tim Fuechsel wrote:
> +static __always_inline bool is_in_min_rtt_probing(struct roccettcp *ca, u32 now)

this seems to not be called, please remove

In general please remove the __always_inline annotations sprinkled
everywhere. Modern compilers will inline things correctly, and it
just hides such unused code warnings.

Please respin for this and whatever else in the sashiko bot response
you consider worth addressing. Looks like TCP experts are on vacation,
maybe v5 will be luckier.
--
pw-bot: cr