Re: [PATCH v22 net-next 01/12] net/nebula-matrix: add minimum nbl build framework

[Jakub Kicinski]

On Thu, 23 Jul 2026 12:00:53 +0800 illusion.wang wrote:
> +config NET_VENDOR_NEBULA_MATRIX
> +	bool "Nebula-matrix devices"
> +	default y
> +	help
> +	  If you have a network (Ethernet) card belonging to this class, say Y.
> +	  Note that the answer to this question doesn't directly affect the
> +	  kernel: saying N will just cause the configurator to skip all
> +	  the questions about Nebula-matrix cards. If you say Y, you will be asked
> +	  for your specific card in the following questions.
> +
> +if NET_VENDOR_NEBULA_MATRIX
> +
> +config NBL
> +	tristate "Nebula-matrix Ethernet Controller m18110/m18000 support"
> +	depends on PCI && (64BIT || COMPILE_TEST) && !CPU_BIG_ENDIAN
> +	help
> +	  This driver supports Nebula-matrix Ethernet Controller m18110/m18000
> +	  Family of devices.  For more information about this product, go to
> +	  the product description with smart NIC:
> +
> +	  <http://www.nebula-matrix.com>

Let's skip the "For more information.. " and the link the sentence
below pointing to Documentation is enough. 

> +	  More specific information on configuring the driver is in
> +	  <file:Documentation/networking/device_drivers/ethernet/nebula-matrix/nbl.rst>.
> +
> +	  To compile this driver as a module, choose M here. The module
> +	  will be called nbl.

> +enum {
> +	NBL_CAP_HAS_CTRL_BIT,
> +	NBL_CAP_HAS_NET_BIT,
> +};

This enum is unused in the patch.
Please don't add unused code, it makes the submission hard to review.