Re: [PATCH 2/3] staging: rtl8723bs: propagate errno handling for mgmt xmit

[Dan Carpenter]

On Fri, Jul 31, 2026 at 07:05:45AM +0000, Hungyu Lin wrote:
> Convert rtw_hal_mgnt_xmit() to return errno-style values and update
> dump_mgntframe_and_wait() to translate the result back to the existing
> _SUCCESS/_FAIL flow. Update the prototype in hal_intf.h accordingly
> 
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++++
>  drivers/staging/rtl8723bs/hal/hal_intf.c      | 9 +++++++--
>  drivers/staging/rtl8723bs/include/hal_intf.h  | 2 +-
>  3 files changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index f5ab94a2d0a0..0027f9333738 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -1990,6 +1990,10 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntfr
>  	pxmitbuf->sctx = &sctx;
>  
>  	ret = rtw_hal_mgnt_xmit(padapter, pmgntframe);
> +	if (ret)
> +		ret = _FAIL;
> +	else
> +		ret = _SUCCESS;
>  
>  	if (ret == _SUCCESS)
>  		ret = rtw_sctx_wait(&sctx);

This is awkward.  I would have allowed it either way, but it's good
to note this kind of thing in the commit message:

"After this change the error checking in dump_mgntframe_and_wait()
becomes quite awkward because we need to convert zero to  _SUCCESS (1)
and negative error codes to _FAIL (0).  A follow on patch will
change the dump_mgntframe_and_wait() to use kernel error codes
consistently."

regards,
dan carpenter