Re: [PATCH net-next 3/3] net: stmmac: fpe: Move fprq configuration to stmmac_fpe_configure_pmac()

From: Jakub Kicinski

Date: Fri Jul 31 2026 - 20:58:43 EST


On Wed, 29 Jul 2026 08:31:39 +0200 Maxime Chevallier wrote:
> Not a bit fan of the writel(u32_replace(readl(...))) but I don't feel strong
> enough about that to warrant a resend

Most definitely +1.

Please fix, respin will be needed because this patch triggers:

include/linux/bitfield.h:221:17: error: call to ‘__bad_mask’ declared with attribute error: bad bitfield mask
221 | __bad_mask();
| ^~~~~~~~~~~~

on x86 builds.