Re: [PATCH] batman-adv: reject unrepresentable multicast TVLV offsets

[Sven Eckelmann]

On Friday, 31 July 2026 17:46:08 CEST Sven Eckelmann wrote:
> On Fri, 31 Jul 2026 13:52:22 +0000, David Lee <david.lee@xxxxxxxxxxxxxxx> wrote:
> > batman-adv: reject unrepresentable multicast TVLV offsets
> 
> Acked-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>

I am hereby withdrawing this.

NACKed-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>

This needs a different implementation and a clean patch submission. Summary:

1. weird text + newlines in the tags section which shouldn't be there

2. author didn't sign off the patch

3. weird unrelated Signed-off-by without any understandable connection to 
   patch

4. the checks should be in the API and not added in random places in callers 
   of the API (which makes it hard to understand why the check is there). The 
   users of the API should only handle the return values of the API functions. 
   See commit d45cf1e7d718 ("ipv6: reject malicious packets in 
   ipv6_gso_segment()")

Regards,
	Sven

Attachment: signature.asc
Description: This is a digitally signed message part.