Re: [PATCH v2 2/2] gpio: sloppy-logic-analyzer: use debugfs_create_file() for buf_size and capture
From: Wolfram Sang
Date: Sat Aug 01 2026 - 16:36:40 EST
On Fri, Jul 31, 2026 at 01:02:58AM +0300, Cengiz Can wrote:
> The "buf_size" and "capture" debugfs files are created with
> debugfs_create_file_unsafe() and DEFINE_DEBUGFS_ATTRIBUTE() fops. That is
> safe on its own: debugfs_attr_read()/write() take a debugfs reference
> themselves, so debugfs_remove_recursive() drains them on removal.
>
> Now that "trigger" uses debugfs_create_file(), switch these two to the
> same call so all three debugfs files in this driver are created uniformly.
> This is a cosmetic change; the extra debugfs_file_get()/put() added by the
> full_proxy wrapper is negligible.
>
> Suggested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Assisted-by: Claude:claude-opus-4.8
> Signed-off-by: Cengiz Can <cengiz.can@xxxxxxxxxxxxx>
I'd squash the patches and keep the stable tag for the combined patch,
but I'll leave this to the GPIO maintainers.
Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature