Re: [PATCH v2 0/2] drm/exynos: DRM encoder improvements for Exynos devices

[Inki Dae]

Hi Diogo,

Thanks for the patch. The conversion itself looks correct.

Two small things to fix:

1. exynos_hdmi.c: double blank line

> +static const struct drm_encoder_funcs exynos_hdmi_encoder_funcs = {
> +   .destroy = drm_encoder_cleanup,
> +};
> +
> +
>  static const struct drm_encoder_helper_funcs exynos_hdmi_encoder_helper_funcs = {

Please drop one of the blank lines. The other four files are fine,
only exynos_hdmi.c has this.

2. exynos_drm_dsi.c: header include order

> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -13,7 +13,7 @@
>  #include <drm/bridge/samsung-dsim.h>
>  #include <drm/drm_probe_helper.h>
> -#include <drm/drm_simple_kms_helper.h>
> +#include <drm/drm_encoder.h>

Here the new include was put in place of the removed one, which breaks
the alphabetical ordering. In the other four files you added
<drm/drm_encoder.h> at the correct sorted position, so please do the
same here:

 #include <drm/bridge/samsung-dsim.h>
 #include <drm/drm_encoder.h>
 #include <drm/drm_probe_helper.h>

Both are trivial, so no need to resend - I will fix them up myself
while applying the patch.

Thanks,
Inki Dae

2026년 7월 5일 (일) 오후 4:54, Diogo Silva <diogompaissilva@xxxxxxxxx>님이 작성:
>
> Hi Inki,
>
> > It looks like you may have forgotten to post the v2 patch. Could you
> > please check?
>
> I think they are here:
> https://lore.kernel.org/all/20260623-exynos-drm-simple-v2-1-a8d59678b7d2@xxxxxxxxx/
> https://lore.kernel.org/all/20260623-exynos-drm-simple-v2-2-a8d59678b7d2@xxxxxxxxx/
>
> If I did something wrong tell me and I will re-send them.
>
> Thanks,
> Diogo