Re: [PATCH] blk-throttle: remove dead field last_check_time from throtl_grp

[yu kuai]

在 2026/7/17 13:48, Tao Cui 写道:

> From: Tao Cui<cuitao@xxxxxxxxxx>
>
> The last_check_time field in throtl_grp was used by the
> CONFIG_BLK_DEV_THROTTLING_LOW mechanism (in throtl_upgrade_check() and
> the downgrade logic) to timestamp the last upgrade/downgrade check.
>
> Commit bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW")
> removed all five of its uses in blk-throttle.c and the surrounding LOW
> fields (latency_target, last_finish_time, checked_last_finish_time,
> avg_idletime, idletime_threshold, bio_cnt, bad_bio_cnt,
> bio_cnt_reset_time), but missed the field definition itself.
>
> It has been a dead field since then: zero references in blk-throttle.c
> and the whole tree.  Remove it.
>
> Signed-off-by: Tao Cui<cuitao@xxxxxxxxxx>
> ---
>   block/blk-throttle.h | 2 --
>   1 file changed, 2 deletions(-)
Reviewed-by: Yu Kuai <yukuai@xxxxxxx>

-- 
Thanks,
Kuai