Re: [PATCH net-next 1/2] net: stmmac: ethtool: Comment the magic numbers in RIWT computation

From: Andrew Lunn

Date: Sun Aug 02 2026 - 11:02:57 EST


On Sun, Aug 02, 2026 at 01:40:13PM +0200, Maxime Chevallier wrote:
> Receive Interrupt Watchdog Timer is an RX interrupt coalescing mechanism
> used by some variants of dwmac. It allows waiting a bit before
> triggering the rx interrupts, allowing for batch processing.
>
> The RIWT is configured with a granularity of 256 stmmac clk ticks. Let's
> add a comment for that and wrap the raw "1000000" into USEC_PER_SEC, as
> we're computing "how many clock cycles in one microsec" with that step.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew