Re: [PATCH net-next v4 06/12] ax88179_178a: Add VLAN offload support for AX88179A

[Andrew Lunn]

On Fri, Jul 31, 2026 at 06:19:06PM +0200, Birger Koblitz wrote:
> The AX88179A-based chips support VLAN offload. Add configuration
> support in netdev_ops. Features supported are:
> NETIF_F_HW_VLAN_CTAG_TX, NETIF_F_HW_VLAN_CTAG_RX
> and NETIF_F_HW_VLAN_CTAG_FILTER.
> 
> Signed-off-by: Birger Koblitz <mail@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/net/usb/ax88179_lib.c      |   2 +
>  drivers/net/usb/ax88179a_devices.c | 100 +++++++++++++++++++++++++++++++++++++
>  2 files changed, 102 insertions(+)
> 
> diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
> index 7b5c17a01df2deac2cc0210bc88193be1abfbe23..26c874b31beafac796264e46ecc942b4bd460ac0 100644
> --- a/drivers/net/usb/ax88179_lib.c
> +++ b/drivers/net/usb/ax88179_lib.c
> @@ -348,6 +348,7 @@ int ax88179_set_features(struct net_device *net, netdev_features_t features)
>  {
>  	u8 tmp;
>  	struct usbnet *dev = netdev_priv(net);
> +	struct ax88179_data *data = dev->driver_priv;
>  	netdev_features_t changed = net->features ^ features;

So reverse christmas tree is normal for netdev. This is right way up
christmas tree, and the existing code is broken, so O.K.

> +static int ax88179a_set_features(struct net_device *net, netdev_features_t features)
> +{
> +	u8 tmp;
> +	int ret;
> +	struct usbnet *dev = netdev_priv(net);
> +	netdev_features_t changed = net->features ^ features;

This however is new code, so should be correct.

	Andrew