Re: [PATCH net-next v5 04/13] ax88179_178a: Add HW support for AX179A-based chips

[Andrew Lunn]

> +static void ax88179a_bulkin_config(struct usbnet *dev, u8 link_sts)
> +{
> +	struct ax88179_data *ax179_data = dev->driver_priv;
> +	const struct ax_bulkin_settings *bulkin_data;
> +	int index = 0;
> +
> +	switch (ax179_data->speed) {

What is setting ->speed?

> +static void ax88179a_mac_link_up(struct phylink_config *config,
> +				 struct phy_device *phy,
> +				 unsigned int phy_mode, phy_interface_t interface,
> +				 int speed, int duplex,
> +				 bool tx_pause, bool rx_pause)
> +{

It should be coming from there, but i don't see any code setting it.

> +	ax88179_read_cmd(dev, AX_ACCESS_MAC, PHYSICAL_LINK_STATUS, 1, 1, &link_sts);
> +	ax88179a_bulkin_config(dev, link_sts);

It might be better to pass speed as a parameter.

I would probably play with ethtool and set the advertised speeds to
only include slower speeds, like 10Half, and make sure the link works
correctly.

	Andrew