Re: [PATCH v4 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver

From: Uwe Kleine-König

Date: Sun Aug 02 2026 - 18:23:58 EST


Hello,

On Sat, Aug 01, 2026 at 12:26:54AM -0700, Changhuang Liang wrote:
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>

Please don't include <linux/mod_devicetable.h>, which will go away soon.
<linux/platform_device.h> already contains the necessary bits to have
of_device_id defined, so you can just drop the #include for
<linux/mod_devicetable.h>.

This also affects several other patches in this series.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature