RE: [PATCH v2 11/11] wifi: rtw88: run the RTL8723BS association register sequence

[Ping-Ke Shih]

Luka Gejak <luka.gejak@xxxxxxxxx> wrote:

(thanks for your above experiments)

> 
> That leaves prep at six patches:
> 
>   1 add the RTL8723B chip type and SDIO helper
>   2 rx: mark zero length packets on RTL8723BS
>   3 fw: fix the reserved page upload on RTL8723BS
>   4 sdio: track free TX pages and OQT credits for RTL8723BS
>   5 sdio: set up RX aggregation and interrupts for RTL8723BS
>   6 sdio: add TX back-pressure and retry on page starvation

Answer your question below, smaller patchset is always better to me. :)
Unless it is too small to understand whole picture.

> 
> and no chip tests left in mac80211.c or coex.c. What remains is one in
> rx.c, one in fw.c and eleven in sdio.c, all of which you have already
> said are fine inline.
> 
> With step 3 gone your ordering collapses to prep, then the chip driver,
> then Kconfig/Makefile, then MAINTAINERS. Would you rather have that as
> one series of nine patches, or keep the current split with prep sent
> first? I am happy either way; one series removes the "wait for prep to
> land" coordination.

One thing I forgot to say is that the step 2 (add RTL8723BS) can be split
into patches per file. Reviewing can be easier. 

> 
> One detail for the ordering: a few register defines currently sit in
> the patches being dropped but are used by rtw8723b.c, so they move into
> the chip support patch. 

Yes. That is good to me.

Ping-Ke