Re: [PATCH net-next 3/3] net: stmmac: fpe: Move fprq configuration to stmmac_fpe_configure_pmac()
From: Nazle Asmade, Muhammad Nazim Amirul
Date: Sun Aug 02 2026 - 23:31:47 EST
On 1/8/2026 8:55 am, Jakub Kicinski wrote:
> On Wed, 29 Jul 2026 08:31:39 +0200 Maxime Chevallier wrote:
>> Not a bit fan of the writel(u32_replace(readl(...))) but I don't feel strong
>> enough about that to warrant a resend
>
> Most definitely +1.
>
> Please fix, respin will be needed because this patch triggers:
>
> include/linux/bitfield.h:221:17: error: call to ‘__bad_mask’ declared with attribute error: bad bitfield mask
> 221 | __bad_mask();
> | ^~~~~~~~~~~~
>
> on x86 builds.
Hi Jakub,
Reposted with v3
https://lore.kernel.org/all/20260803032358.16282-1-muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx/
Maxime,
i need to revert to original one since this one reproduce an error.
Please review it as i still include your tag. Thanks!
BR,
Nazim