Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add HAMOA-IOT-COME board

[yuanjiey]

On Thu, Jul 30, 2026 at 12:23:56PM +0200, Krzysztof Kozlowski wrote:
> On 30/07/2026 12:08, Krzysztof Kozlowski wrote:
> > On 30/07/2026 11:54, yuanjiey wrote:
> >> On Thu, Jul 30, 2026 at 08:51:40AM +0200, Krzysztof Kozlowski wrote:
> >>> On Mon, Jul 27, 2026 at 03:07:16PM +0800, Yuanjie Yang wrote:
> >>>> Document the device tree binding for the HAMOA-IOT-COME board based on
> >>>> the Qualcomm X1E80100 SoC.
> >>>>
> >>>> The platform consists of a system-on-module (SoM) mounted on a carrier
> >>>> board. The SoM integrates the core system functionality, including a
> >>>> SiP containing the X1E80100 SoC and its supporting components.
> >>>>
> >>>> The COME SiP hardware is effectively the same as the SoM used on the
> >>>
> >>> Effectively the same or the same? I googled for "hamoa iot come" and it
> >>> gives me zero results. Provide some URLs describing both.
> >> The same.
> >>
> >>
> >> Here is pdf about the "hamoa iot come" SiP and SoM
> >> link: https://advdownload.advantech.com.cn/productfile/PIS/SOM-6820/file/SOM-6820_DS(052925)20250529110758.pdf
> >>
> >> The preliminary figure provides a complete overview of architecture, including the SiP, SoM.
> >>
> >> In Block Diagram
> >> hamoa come Qualcomm X-Elite SiP Module is the SoM on haoma evk.
> > 
> > I see on that PDF "SOM-6820", not "Hamoa IoT Come".
> > 
> > I have an impression that all this and previous bindings and DTs did not
> > match reality at all. Or did not match how upstream works with such
> > hardware.
> > 
> 
> Adding more: I did ask in the past to properly represent SoM and
> carriers. I pointed to other examples how this is done correctly. I did
> look now inside and found absolutely no reference of actual product
> called "Hamoa IoT" or "Purwa IoT". For sure there is no "Hamoa IoT Come"
> SoM (sometimes COMe appears).

I check the hamoa iot evk board page:
https://docs.qualcomm.com/doc/80-77183-262/topic/Getting-started.html#get-familiar
and 
purwa iot evk board page:
https://docs.qualcomm.com/doc/80-80022-297/80-80022-297_REV_AC_Qualcomm_IQ-X_Series_Evaluation_Kit_-_Linux_Bringup_guide.pdf

And I see below info:

Dragonwing IQ-X7xxx EVK components:
The kit includes the following components:
Dragonwing IQ-X7xxx EVK mainboard
"System in package (SiP) "

I think the current naming of hamoa-iot-som.dtsi and purwa-iot-som.dtsi in the
Linux device tree is incorrect. They should be renamed to hamoa-iot-sip.dtsi
and purwa-iot-sip.dtsi.

hamoa-iot-som.dtsi --> hamoa-iot-sip.dtsi
purwa-iot-som.dtsi --> purwa-iot-sip.dtsi

> Look, this is a SoM:
> https://www.toradex.com/computer-on-modules/verdin-arm-family/nxp-imx95
> 
> And you can find corresponding bindings and DTS in tree.
> 
> I refuse to accept more of this fake products trying to imitate well
> known industry standards in their own way and effectively pushing some
> downstream crap, just because that's how we do it in downstream.
> 
> Unless you can present us with such product details matching what you
> send, I will be NAK-ing these and future patches like that.

Thanks for your tips:

I check hamoa come som page:
https://advdownload.advantech.com.cn/productfile/PIS/SOM-6820/file/SOM-6820_DS(052925)20250529110758.pdf
and come board page:
https://www.advantech.com.cn/zh-cn/products/1-fc23ff/som-db5830/mod_16b1a718-27d6-4a4c-8684-e8f2a8e9c57b

So I should rename come binding with real devices name:
binding should be:

      - items:
          - enum:
              - hamoa-som6820-db5830.dts
          - const: hamoa-som6820.dtsi
          - const: qcom,hamoa-iot-sip
          - const: qcom,x1e80100


Thanks,
Yuanjie

> Best regards,
> Krzysztof