Re: [PATCH v6 2/6] tools/lib/mm: add shared file helpers
From: Mike Rapoport
Date: Mon Aug 03 2026 - 05:07:32 EST
> Move read_file(), write_file(), read_num(), and write_num() out of
> tools/testing/selftests/mm/vm_util.c into a new shared helper under
> tools/lib/mm/.
>
> @@ -187,8 +188,8 @@ TEST_FILES += write_hugetlb_memory.sh
>
> include ../lib.mk
>
> -$(TEST_GEN_PROGS): vm_util.c hugepage_settings.c
> -$(TEST_GEN_FILES): vm_util.c hugepage_settings.c
> +$(TEST_GEN_PROGS): vm_util.c hugepage_settings.c $(top_srcdir)/tools/lib/mm/file_utils.c
> +$(TEST_GEN_FILES): vm_util.c hugepage_settings.c $(top_srcdir)/tools/lib/mm/file_utils.c
I was too lazy to change the Makefile, but we should do something to
compile those once and link to every TEST_PROG that uses them.
--
Sincerely yours,
Mike.