Re: [PATCH RFC 2/2] rust: usb: add control message send and receive
From: Alrexandru Radovici
Date: Mon Aug 03 2026 - 07:45:49 EST
On Sun Aug 2, 2026 at 11:32 AM EEST, Greg Kroah-Hartman wrote:
> On Sat, Aug 01, 2026 at 03:01:08AM +0300, Alexandru Radovici wrote:
>> Add `Device::send_control_message()` and
>> `Device::receive_control_message()`, wrapping usb_control_msg_send()
>> and usb_control_msg_recv(), plus a `Request` type describing the
>> bmRequestType, bRequest, wValue and wIndex fields of a setup packet.
>
> Why not keep the names as close as possible to the C calls? You have
> switched around the noun/verb use here.
Sorry, my bad, I will rename them in v2 to `control_message_send` and
`control_message_receive`. Thanks for pointing this out.
> thanks,
>
> greg k-h
Alexandru