Re: [PATCH 07/21] dt-bindings: net: x-powers: add AC200 EPHY control

From: Andrew Lunn

Date: Mon Aug 03 2026 - 09:58:15 EST


> + phy-mode:
> + enum:
> + - mii
> + - rmii

Despite the phy- bit, phy-mode is a MAC property, it defines the MII
the MAC uses. I would not expect to see this anywhere else.

The PHY driver is told what MII to use, phydev->interface, which takes
the values PHY_INTERFACE_MODE_RMII, PHY_INTERFACE_MODE_MII etc.

Please explain why you need this here, why is the MAC nodes phy-mode
property not sufficient.

Andrew