Re: [PATCH 0/2] x86: Use "er" asm constriant for add/sub

[David Laight]

On Mon, 3 Aug 2026 10:49:40 -0400 (EDT)
Nicolas Pitre <nico@xxxxxxxxxxx> wrote:

> On Mon, 3 Aug 2026, David Laight wrote:
> 
> > The x86 instruction set only supports 32bit signed immediate values
> > for add/sub.
> > Replace the "ir" constraint with "er" to avoid build errors.
> > 
> > Found by a patch that added used mul_u64_add_u64_div_u64() to
> > do a rounding divide by 2^32 (perhaps not the best way to do this).
> > 
> > A quick grep only found one other affected file.  
> 
> Would be a good idea adding those cases to the test module.

They fail to compile so it isn't a big deal.

	David

> 
> 
> Nicolas