Re: [PATCH] HID: amd_sfh: return an error when response wait times out

From: Jiri Kosina

Date: Mon Aug 03 2026 - 13:31:54 EST


On Wed, 24 Jun 2026, Pengpeng Hou wrote:

> amdtp_wait_for_response() waits for request_done before completing a
> report request. wait_event_interruptible_timeout() returns 0 when the
> wait expires, but the current code treats only negative values as errors
> and returns success on timeout.
>
> Return -ETIMEDOUT when the response wait expires while preserving the
> existing success path when the response has already been observed.
>
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>

Basavaraj, could you please review/ack this?

Thanks,

--
Jiri Kosina
SUSE Labs