Re: [PATCH v3 0/4] HID: Remove redundant error messages on IRQ request failure

[Jiri Kosina]

On Mon, 20 Jul 2026, Pan Chuang wrote:

> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()") added automatic error logging to
> devm_request_threaded_irq() and devm_request_any_context_irq()
> via the new devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code on failure.
> 
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
> 
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in hid drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.
> 
> v1 -> v2:
> - Added the same change for the intel-quicki2c driver
> 
> v2 -> v3:
> - amd_sfh: directly return devm_request_irq() result

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs