Re: [PATCH v2 3/3] dt-bindings: rtc: ti,omap-rtc: Convert to DT schema

[Rob Herring]

On Sat, Jul 25, 2026 at 02:31:58AM +0530, Bhargav Joshi wrote:
> Convert the Texas Instruments OMAP Real Time Clock (RTC) binding from
> the legacy text format to the DT schema. Mark 'ti,hwmods' as deprecated
> as it is no longer used, it is kept to support legacy boards.
> 
> Signed-off-by: Bhargav Joshi <j.bhargav.u@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/rtc/rtc-omap.txt |  53 --------
>  .../devicetree/bindings/rtc/ti,omap-rtc.yaml       | 149 +++++++++++++++++++++
>  2 files changed, 149 insertions(+), 53 deletions(-)
> 

> diff --git a/Documentation/devicetree/bindings/rtc/ti,omap-rtc.yaml b/Documentation/devicetree/bindings/rtc/ti,omap-rtc.yaml
> new file mode 100644
> index 000000000000..326d5ad97292
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ti,omap-rtc.yaml
> @@ -0,0 +1,149 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/ti,omap-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments OMAP Real Time Clock
> +
> +maintainers:
> +  - Keerthy <j-keerthy@xxxxxx>
> +  - Afzal Mohammed <afzal@xxxxxx>
> +
> +description:
> +  The OMAP RTC is a year/month/day/hours/minutes/seconds BCD clock with
> +  century-range alarm matching, driven by the 32kHz clock.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: ti,da830-rtc
> +      - const: ti,am3352-rtc

am3352 is either compatible with da830 or it isn't. You can't have both. 
I would drop this entry. You don't have the fix the .dts (or can do that 
separately).

> +      - items:
> +          - const: ti,am3352-rtc
> +          - const: ti,da830-rtc
> +      - items:
> +          - const: ti,am4372-rtc
> +          - const: ti,am3352-rtc
> +          - const: ti,da830-rtc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 2
> +    maxItems: 2
> +
> +  system-power-controller:
> +    type: boolean
> +    description:
> +      Indicates that this RTC controls system power via the pmic_power_en pin.
> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 2
> +
> +  clock-names:
> +    oneOf:
> +      - items:
> +          - const: ext-clk
> +          - const: int-clk
> +      - items:
> +          - const: ext-clk
> +      - items:
> +          - const: int-clk

This can be just:

minItems: 1
items:
  - enum [ ext-clk, int-clk ]
  - const: int-clk


> +
> +  pinctrl-0:
> +    description:
> +      Phandle to pin configuration for the external wakeup pins.
> +
> +  pinctrl-names:
> +    minItems: 1
> +
> +  ti,hwmods:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      Name of the hwmod associated with the RTC.
> +    const: rtc
> +    deprecated: true
> +
> +patternProperties:
> +  "^ext-wakeup(-[0-9]+)?$":
> +    type: object
> +
> +    description:
> +      Child node describing external wakeup pin configuration.
> +
> +    properties:
> +      pins:
> +        enum:
> +          - ext_wakeup0
> +          - ext_wakeup1
> +          - ext_wakeup2
> +          - ext_wakeup3

pattern: '^ext_wakeup[0-3]$'