Re: [PATCH v19 12/14] cxl: Add port and dport identifiers to CXL AER trace events

From: Alison Schofield

Date: Mon Aug 03 2026 - 22:28:11 EST


On Mon, Aug 03, 2026 at 05:18:08PM -0500, Terry Bowman wrote:
> From: Dan Williams <djbw@xxxxxxxxxx>
>
> Pass struct cxl_port * and struct cxl_dport * to the cxl_aer_*
> trace events instead of a plain struct device * derived at the
> caller. The trace event helpers then derive the right strings for
> Endpoints, Switch Ports, Root Ports, and RCH Downstream Ports
> consistently across the CPER and native AER paths.
>
> The unified cxl_aer_* events keep "memdev" as the legacy field
> (endpoint events populate it with the memdev name; non-endpoint
> events emit memdev="") and add new "port" and "dport" string fields
> populated for all CXL device classes. Updated userspace can key
> off "port" and "dport" without a parallel set of events.
>
> Remove the separate cxl_port_aer_uncorrectable_error and
> cxl_port_aer_correctable_error trace events. All CXL AER events now
> use the unified cxl_aer_* events with port and dport fields.
>
> Rework cxl_cper_handle_prot_err() to use find_cxl_port_by_dev() and
> the unified trace helpers, replacing the per-port-type branching and
> bus_find_device() memdev lookup.


Reviewed-by: Alison Schofield <alison.schofield@xxxxxxxxx>