Re: [PATCH v4 2/2] f2fs: protect critical_task_priority updates with s_umount

[Chao Yu]

On 8/4/26 09:48, Wenjie Qi wrote:
> The sysfs store path already takes s_umount for GC thread control
> entries, and ckpt_thread_ioprio is covered as well.
>
> critical_task_priority also updates checkpoint or GC kthread scheduling
> state, but it is not covered by that serialization. It can race with
> remount or teardown paths that are stopping those threads.
>
> Protect critical_task_priority sysfs writes with s_umount too.
>
> Fixes: 52190933c37a ("f2fs: sysfs: introduce critical_task_priority")
> Cc: stable@xxxxxxxxxx
> Signed-off-by: Wenjie Qi <qiwenjie@xxxxxxxxxx>

Reviewed-by: Chao Yu <chao@xxxxxxxxxx>

Thanks,