Re: [PATCH v2 01/64] dmaengine: add tasklet-backed channel BH helpers

[Allen]

>
> >  void dma_release_channel(struct dma_chan *chan);
> >  int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps);
> > +void dma_chan_init_bh(struct dma_chan *chan, dma_chan_bh_work_fn fn);
> > +bool dma_chan_schedule_bh(struct dma_chan *chan);
> > +void dma_chan_kill_bh(struct dma_chan *chan);
>
> Can you please name these as dmaengine_xxx. Yes we have mix of these
> two, but I would like to see new ones move to dmaengine_xx and then
> progressively drop dma_ everywhere
>

Thanks, Vinod.

  I will rename the new helpers to dmaengine_* in v3.

  I also see that patch 1 removes the virt-dma tasklet before all of its
  direct users are converted, leaving the intermediate tree unbuildable and
  breaking bisectability. I will fold those call-site conversions into patch
  1. The patches that contain only those conversions will then become empty,
  which will shorten the series considerably.

  Regards,
  Allen


> --
> ~Vinod