Re: [PATCH v3 4/5] gpu: nova-core: split FbLayout into FSP and non-FSP versions

[Alexandre Courbot]

On Fri Jul 24, 2026 at 3:56 PM JST, Eliot Courtney wrote:
> `FbLayout` is currently used for both pre and post FSP architectures. It
> contains ranges for each region of framebuffer, but on post FSP
> architectures, only the size is actually used by GSP. The offsets are
> not decided by the driver. So, for post FSP architectures `FbLayout`
> contains essentially guesses for the offsets. Instead, make separate
> types so that we only store the information that's actually needed,
> rather than keeping around offsets that may not be correct.
>
> Signed-off-by: Eliot Courtney <ecourtney@xxxxxxxxxx>

This one doesn't apply anymore after the vGPU series; rebasing is not
too difficult, but I prefer to let you decide how to do it. I guess we
will need a new function to compute `(vf_partition_count,
wpr2_heap_size)` that is shared between `FbRanges` and `FbSizes`.

With this and Danilo's comments addressed this looks clean and ready to
merge. Thanks for reordering the patches!