Re: [PATCH] pinctrl: Use IRQ trigger mask helpers

From: Viresh Kumar

Date: Tue Aug 04 2026 - 00:26:56 EST


On 02-08-26, 19:35, Maulik Shah wrote:
> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
> index 1ec22010a3f9..5fcbea32089d 100644
> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
> @@ -339,7 +339,7 @@ static int plgpio_irq_set_type(struct irq_data *d, unsigned trigger)
> if (plgpio->regs.eit == -1)
> supported_type = IRQ_TYPE_LEVEL_HIGH;
> else
> - supported_type = IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING;
> + supported_type = IRQ_TYPE_EDGE_BOTH;
>
> if (!(trigger & supported_type))
> return -EINVAL;

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh