Re: [PATCH] riscv: kprobes: Prevent probes in breakpoint handlers

From: Nam Cao

Date: Tue Aug 04 2026 - 03:11:41 EST


"Rui Qi" <qirui.001@xxxxxxxxxxxxx> writes:
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index 2f57fd48ec28..5eb5785874dd 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -270,6 +270,8 @@ static bool probe_single_step_handler(struct pt_regs *regs)
> return user ? uprobe_single_step_handler(regs) : kprobe_single_step_handler(regs);
> }
>
> +NOKPROBE_SYMBOL(probe_single_step_handler);
> +

The usual style is NOKPROBE_SYMBOL() following the function with no
blank line.

Other than that:
Reviewed-by: Nam Cao <namcao@xxxxxxxxxxxxx>