Re: [PATCH] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call
From: Hongfu Li
Date: Tue Aug 04 2026 - 05:22:26 EST
On 8/4/26 4:24 PM, Lorenzo Stoakes (ARM) wrote:
On Tue, Aug 04, 2026 at 09:20:37AM +0100, Lorenzo Stoakes (ARM) wrote:Thanks a lot for your review. I will adjust ksft_set_plan() from 88 to 87 in main() and
On Tue, Aug 04, 2026 at 02:24:40PM +0800, Hongfu Li wrote:Sorry Pedro mentioned off-list that you need to update the number of tests
From: Hongfu Li <lihongfu@xxxxxxxxxx>:))
mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
The second run repeats all assertions with no benefit. Drop the
duplicate call.
Signed-off-by: Hongfu Li <lihongfu@xxxxxxxxxx>
LGTM so
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
specified, e.g.:
- ksft_set_plan(88);
+ ksft_set_plan(87);
In main().
Update that and send a respin and you can attach my tag to it.
send a respin carrying your Reviewed-by.
--
Best regards,
Hongfu