Re: [PATCH v2] tty: serial: max3100: shut down timer before freeing port

[Fan Wu]

Hi Greg,

Sorry, I don't have MAX3100 hardware, so I have not tested this on
hardware.

You're right about the extra state. I'll rework the cleanup to use the
existing startup/unwind state instead of adding irq_registered, then
send v3 after rebuilding it.

Thanks,
Fan

> On Aug 3, 2026, at 20:56, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> LLMs _love_ to use boolean flags to attempt to figure things out that
> they can't seem to determine.  Are you _SURE_ this really is needed?
> How about unwinding things better so it's not required?  You are just
> adding another "state" to the device, adding to the complexity overall,
> which is generally not a good idea.
> 
> And do you have this hardware to test this with?
> 
> thanks,
> 
> greg k-h