Re: [PATCH] staging: rtl8723bs: disable SDIO function on block size failure

[Dan Carpenter]

On Sat, Aug 01, 2026 at 01:17:10AM +0900, Myeonghun Pak wrote:
> sdio_init() enables the SDIO function before configuring the block
> size. If sdio_set_block_size() fails, the function jumps to the release
> path and returns the error without disabling the SDIO function. The
> caller then frees the dvobj directly, so the enabled SDIO function is
> left active on that probe failure path.
> 
> Disable the SDIO function before releasing the host when block size
> configuration fails.
> 
> This issue was identified during our ongoing static-analysis research while
> reviewing kernel code.
> 
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> ---

Looks good.

Reviewed-by: Dan Carpenter <error27@xxxxxxxxx>

regards,
dan carpenter