Re: [PATCH 03/12] drm/panthor: Move the debugfs initialization to panthor_device.c

[Liviu Dudau]

On Tue, Aug 04, 2026 at 12:09:42PM +0200, Boris Brezillon wrote:
> Those are per-device debugfs-files, so it makes sense to have the
> initialization logic in panthor_device.c.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>

Reviewed-by: Liviu Dudau <liviu.dudau@xxxxxxx>

Best regards,
Liviu

> ---
>  drivers/gpu/drm/panthor/panthor_device.c |  9 +++++++++
>  drivers/gpu/drm/panthor/panthor_device.h |  4 ++++
>  drivers/gpu/drm/panthor/panthor_drv.c    | 10 +---------
>  3 files changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_device.c b/drivers/gpu/drm/panthor/panthor_device.c
> index 1aa86d00646f..7d336f160d1f 100644
> --- a/drivers/gpu/drm/panthor/panthor_device.c
> +++ b/drivers/gpu/drm/panthor/panthor_device.c
> @@ -13,6 +13,7 @@
>  #include <linux/reset.h>
>  
>  #include <drm/drm_drv.h>
> +#include <drm/drm_file.h>
>  #include <drm/drm_managed.h>
>  #include <drm/drm_print.h>
>  
> @@ -616,3 +617,11 @@ int panthor_device_suspend(struct device *dev)
>  	atomic_set(&ptdev->pm.state, PANTHOR_DEVICE_PM_STATE_SUSPENDED);
>  	return 0;
>  }
> +
> +#ifdef CONFIG_DEBUG_FS
> +void panthor_device_debugfs_init(struct drm_minor *minor)
> +{
> +	panthor_mmu_debugfs_init(minor);
> +	panthor_gem_debugfs_init(minor);
> +}
> +#endif
> diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/panthor/panthor_device.h
> index 0fda64fbe5f2..a6b1a2a5fca4 100644
> --- a/drivers/gpu/drm/panthor/panthor_device.h
> +++ b/drivers/gpu/drm/panthor/panthor_device.h
> @@ -403,6 +403,10 @@ int panthor_device_mmap_io(struct panthor_device *ptdev,
>  int panthor_device_resume(struct device *dev);
>  int panthor_device_suspend(struct device *dev);
>  
> +#ifdef CONFIG_DEBUG_FS
> +void panthor_device_debugfs_init(struct drm_minor *minor);
> +#endif
> +
>  static inline int panthor_device_resume_and_get(struct panthor_device *ptdev)
>  {
>  	int ret = pm_runtime_resume_and_get(ptdev->base.dev);
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 46a3080b0b20..924a7ecd3733 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1764,14 +1764,6 @@ static const struct file_operations panthor_drm_driver_fops = {
>  	.fop_flags = FOP_UNSIGNED_OFFSET,
>  };
>  
> -#ifdef CONFIG_DEBUG_FS
> -static void panthor_debugfs_init(struct drm_minor *minor)
> -{
> -	panthor_mmu_debugfs_init(minor);
> -	panthor_gem_debugfs_init(minor);
> -}
> -#endif
> -
>  /*
>   * PanCSF driver version:
>   * - 1.0 - initial interface
> @@ -1807,7 +1799,7 @@ static const struct drm_driver panthor_drm_driver = {
>  	.gem_prime_import_sg_table = panthor_gem_prime_import_sg_table,
>  	.gem_prime_import = panthor_gem_prime_import,
>  #ifdef CONFIG_DEBUG_FS
> -	.debugfs_init = panthor_debugfs_init,
> +	.debugfs_init = panthor_device_debugfs_init,
>  #endif
>  };
>  
> 
> -- 
> 2.55.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯