Re: [PATCH 1/3] parisc/serial: Use generic BASE_BAUD in asm/serial.h

From: Thorsten Blum

Date: Tue Aug 04 2026 - 09:46:14 EST


On Tue, Aug 04, 2026 at 03:29:51PM +0200, Helge Deller wrote:
> Hi Thorsten,
>
> On 8/4/26 15:20, Thorsten Blum wrote:
> > Include asm-generic/serial.h and use the generic BASE_BAUD definition
> > instead of redefining it.
> >
> > Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> > ---
> > arch/parisc/include/asm/serial.h | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
>
> Instead of sending 3 patches, isn't removing arch/parisc/include/asm/serial.h
> and adding the patch below the better approach?

It was a single patch at some point, but since serial.h is otherwise
empty, your approach seems a lot nicer. I'll send a v2.

Thanks,
Thorsten

> diff --git a/arch/parisc/include/asm/Kbuild b/arch/parisc/include/asm/Kbuild
> index d48d158f7241..4fc315085914 100644
> --- a/arch/parisc/include/asm/Kbuild
> +++ b/arch/parisc/include/asm/Kbuild
> @@ -6,3 +6,4 @@ generic-y += kvm_para.h
> generic-y += mcs_spinlock.h
> generic-y += ring_buffer.h
> generic-y += user.h
> +generic-y += serial.h