Re: [PATCH net-next v5 3/3] net: phy: add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver
From: Artem Shimko
Date: Tue Aug 04 2026 - 10:30:37 EST
Hi Andrew,
On Tue, Aug 4, 2026 at 4:26 PM Andrew Lunn <andrew@xxxxxxx> wrote:
> Ah, please add a comment about that. It could be there is a minor
> design issue within the PHY, and this is their workaround. So keep
> it. A comment will then stop reviewers like me asking...
>
> Part of producing a good patch is to try to think of all the questions
> reviewers will ask, and answer them as part of the patch. Either
> comments in the code, to text in the commit message.
Will do. I'll add a comment explaining the hardware reset defaults
and update the commit message.
Thanks for the review!
---
Best regards,
Artem