Re: [PATCH 10/21] net: phy: add X-Powers AC200 EPHY control driver

[Andrew Lunn]

> I agree that the link PHY cannot be identified by reading its
> registers before the package control sequence has run. I do not agree
> that this means an arbitrary ID should be placed in DT, though.

The ability to put the ID in DT is there for two reasons:

1) You cannot enumerate the PHY because of missing clocks etc.
2) The vendor messed up, and did not put a valid ID in registers 2 and 3.

2 does not happen very often, but this is one example. They are
different PHYs, they need different driver code, when you consider the
PHY as a whole.

I also wound not put in an arbitrary ID, pick an unused ID in the
vendors range.

> Both AC200 and AC300 expose the same link-side PHY ID and register
> layout.

No they don't. There are extra registers in different address domains.

	Andrew